Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for gemma architecture models #125

Merged
merged 7 commits into from
Jun 2, 2024
Merged

Support for gemma architecture models #125

merged 7 commits into from
Jun 2, 2024

Conversation

levmckinney
Copy link
Collaborator

@levmckinney levmckinney commented Feb 27, 2024

We also need to bump some dependencies for this since gemma does not exist in the version of transformers we were requiring.

@norabelrose
Copy link
Collaborator

Sounds good, it looks like it's currently failing because the mockmodel doesn't exist on the HF hub or something? I'm not super familiar with your unit tests, I'd need to look at it more carefully.

I'm definitely fine with bumping the transformer dependency, we could also drop Python 3.9 support too while we're at it (enabling | for union types)

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@norabelrose
Copy link
Collaborator

Looks like we're just failing on TypeError: Subscripted generics cannot be used with class and instance checks, shouldn't be hard to fix

@levmckinney levmckinney merged commit 550644a into main Jun 2, 2024
7 checks passed
@levmckinney levmckinney deleted the gemma_suport branch June 2, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants