Drop tautological comparison #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A pointer to a reference cannot be nullptr. If it is, whatever created the reference in the first place has already crashed. If this is to be protected, one should return the pointer and check that.
ktf
requested review from
Barthelemy,
knopers8 and
justonedev1
as code owners
|
@Barthelemy can this be merged and a new release tagged? It's breaking the CI. |
|
@ktf yes |
Barthelemy
pushed a commit
that referenced
this pull request
Jan 28, 2025
A pointer to a reference cannot be nullptr. If it is, whatever created the reference in the first place has already crashed. If this is to be protected, one should return the pointer and check that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pointer to a reference cannot be nullptr. If it is, whatever created the
reference in the first place has already crashed. If this is to be protected,
one should return the pointer and check that.