[WIP] [QC-1176] Display a warning for developers if a registered object is not mergeable #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justonedev1
changed the title
justonedev1
changed the title
|
For the record, we discussed in person, the agreed improvements are:
|
Also marked all unwanted occurances of mergeable with ignore flag
|
I think that I addressed everything that we talked about, but a bit different way. If you would prefer something else, I can do that. |
knopers8
requested changes
Sep 4, 2024
Framework/src/ObjectsManager.cxx
Outdated
| @@ -70,6 +70,9 @@ void ObjectsManager::startPublishing(TObject* object, PublicationPolicy publicat | |||
| ILOG(Warning, Support) << "Object is already being published (" << object->GetName() << "), will remove it and add the new one" << ENDM; | |||
| stopPublishing(object->GetName()); | |||
| } | |||
| if (mergers::isMergeable(object)) { | |||
There was a problem hiding this comment.
I think this should be also disabled by the presence of QUALITYCONTROL_POSTPROCESSINTERFACE_H and IgnoreMergable==true, otherwise we will see a lot of spurious warnings.
There was a problem hiding this comment.
@justonedev1 can you explain how your most recent changes make QUALITYCONTROL_POSTPROCESSINTERFACE_H disable this warning? I'm not convinced they do.
Framework/src/ObjectsManager.cxx
Outdated
| @@ -70,6 +70,9 @@ void ObjectsManager::startPublishing(TObject* object, PublicationPolicy publicat | |||
| ILOG(Warning, Support) << "Object is already being published (" << object->GetName() << "), will remove it and add the new one" << ENDM; | |||
| stopPublishing(object->GetName()); | |||
| } | |||
| if (mergers::isMergeable(object)) { | |||
| ILOG(Warning, Support) << "Object '" + std::string(object->GetName()) + "' with type '" + std::string(object->ClassName()) + "' is not one of the mergeable types, it might cause issues during publishing"; | |||
There was a problem hiding this comment.
Suggested change
| ILOG(Warning, Support) << "Object '" + std::string(object->GetName()) + "' with type '" + std::string(object->ClassName()) + "' is not one of the mergeable types, it might cause issues during publishing"; | |
| ILOG(Warning, Support) << "Object '" + std::string(object->GetName()) + "' with type '" + std::string(object->ClassName()) + "' is not one of the mergeable types, it will not be correctly merged in distributed setups, such as P2 and Grid" << ENDM; |
missing ENDM and rephrasing
knopers8
reviewed
Oct 2, 2024
| @@ -257,7 +257,7 @@ void TrendingTask::generatePlots() | |||
| } | |||
| auto c = drawPlot(plotConfig); | |||
| mPlots[plotConfig.name].reset(c); | |||
| getObjectsManager()->startPublishing(c, PublicationPolicy::Once); | |||
| getObjectsManager()->startPublishing<true>(c, PublicationPolicy::Once); | |||
There was a problem hiding this comment.
you should not need <true> in TrendingTask and SliceTrendingTask anymore, after you disabled the check for postprocessing tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is just a draft with an idea, how to do it compile time, I am not sure, that you like it. It does not build, it would need a bit more work. Otherwise I don't know how to do this compile time and it would need to be done run time via
dynamic_cast