PWGHF/HFL: Add 2DHistogram in electronselection table and correct electron trackid in HFelectron correlationtask #7751
+460
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete taskHfeSelection.cxx
Delete ElectronSelectionTable.h
Delete CMakeLists.txt
remove thnsparce in taskCorrelationHfeHadrons
rashigupt
requested review from
alibuild,
vkucera,
fcolamar,
fgrosa,
fcatalan92,
mfaggin,
mmazzilli,
deepathoms,
NicoleBastid,
hahassan7,
jpxrk and
apalasciano
as code owners
deepathoms
requested changes
Sep 28, 2024
| @@ -135,7 +135,7 @@ struct HfCorrelatorHfeHadrons { | |||
| registry.fill(HIST("hptElectron"), ptElectron); | |||
| for (const auto& hTrack : tracks) { | |||
|
|
|||
| if (hTrack.globalIndex() == eTrack.globalIndex()) | |||
| if (hTrack.globalIndex() == eTrack.gTrackId()) | |||
There was a problem hiding this comment.
It is not clear why globalIndex() is used for hadron track and gTrackId() is used for electron track. This can be error prone. If there is an issue with globalIndex function in the electron table, I would suggest to investigate that and fix it.
rashigupt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced THnSparse with a 2D histogram to prevent failures with larger datasets in the electron selection task.