PWGHF: new task for W/Z->e in mid-rapidity #7582
Open
+260
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashingo
requested review from
alibuild,
vkucera,
fcolamar,
fgrosa,
fcatalan92,
mfaggin,
mmazzilli,
deepathoms,
NicoleBastid,
hahassan7,
jpxrk and
apalasciano
as code owners
vkucera
requested changes
Sep 5, 2024
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
Co-authored-by: Vít Kučera <vit.kucera@cern.ch>
|
Dear Vit, |
vkucera
reviewed
Sep 6, 2024
vkucera
requested changes
Sep 6, 2024
|
recommitted after implementing suggestions by Vit |
|
Thanks @sashingo for implementing the comments. |
vkucera
reviewed
Sep 10, 2024
|
Hello, I think I address all the comments by Vit. |
NicoleBastid
approved these changes
Sep 25, 2024
NicoleBastid
previously approved these changes
Sep 25, 2024
auto-merge was automatically disabled
September 30, 2024 08:25
Head branch was pushed to by a user without write access
vkucera
requested changes
Sep 30, 2024
Comment on lines
210
to
214
| if (dPhi > o2::constants::math::PI) { | ||
| dPhi -= 2 * o2::constants::math::PI; | ||
| } else if (dPhi < -o2::constants::math::PI) { | ||
| dPhi += 2 * o2::constants::math::PI; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (dPhi > o2::constants::math::PI) { | |
| dPhi -= 2 * o2::constants::math::PI; | |
| } else if (dPhi < -o2::constants::math::PI) { | |
| dPhi += 2 * o2::constants::math::PI; | |
| } | |
| dPhi = RecoDecay::constrainAngle(dPhi, -o2::constants::math::PI); |
Requires including RecoDecay.h.
| registry.fill(HIST("hMatchPhi"), phiEmc, match.track_as<TrackEle>().phi()); | ||
| registry.fill(HIST("hMatchEta"), etaEmc, match.track_as<TrackEle>().eta()); | ||
|
|
||
| double R = std::sqrt(std::pow(dPhi, 2) + std::pow(dEta, 2)); |
There was a problem hiding this comment.
Suggested change
| double R = std::sqrt(std::pow(dPhi, 2) + std::pow(dEta, 2)); | |
| double r = RecoDecay::sqrtSumOfSquares(dPhi, dEta); |
Comment on lines
221
to
223
| Rmim = R; | ||
| dPhi_mim = dPhi; | ||
| dEta_mim = dEta; |
There was a problem hiding this comment.
Suggested change
| Rmim = R; | |
| dPhi_mim = dPhi; | |
| dEta_mim = dEta; | |
| rMin = r; | |
| dPhiMin = dPhi; | |
| dEtaMin = dEta; |
| double dEta_mim = 999.9; | ||
|
|
||
| if (tracksofcluster.size()) { | ||
| int nmatch = 0; |
There was a problem hiding this comment.
Suggested change
| int nmatch = 0; | |
| int nMatch = 0; |
Comment on lines
257
to
258
| return WorkflowSpec{ | ||
| adaptAnalysisTask<HfTaskElectronWeakBoson>(cfgc)}; |
There was a problem hiding this comment.
Suggested change
| return WorkflowSpec{ | |
| adaptAnalysisTask<HfTaskElectronWeakBoson>(cfgc)}; | |
| return WorkflowSpec{adaptAnalysisTask<HfTaskElectronWeakBoson>(cfgc)}; |
|
Hi Vit, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PWGHF: a new task for W/Z decay to electron in midrapidity in Run3