[O2B-1386] Check if clipboard is available #1774
Open
+53
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariscalromeroalejandro
requested review from
graduta and
martinboulais
as code owners
martinboulais
requested changes
Oct 3, 2024
| * | ||
| * @returns {{ available: boolean, message: string }} | ||
| * - `available`: True if the clipboard is available; false otherwise. | ||
| * - `message`: A reason if the clipboard is not available, otherwise an empty string. |
There was a problem hiding this comment.
If message do not apply (meaning: it makes no sense to have a message, in the case the clipboard is available) you should rather use null or undefined (basically return { available: true }).
Another possibility is to have a function like checkClipboardAvailability that throws an error if one of the check fails, and you use the error message as message.
| @@ -59,6 +110,8 @@ export class CopyToClipboardComponent extends StatefulComponent { | |||
| { | |||
| id: `copy-${id}`, | |||
| onclick: () => this.copyToClipboard(clipboardTargetValue), | |||
| disabled: !available, | |||
| title: `${message}`, | |||
There was a problem hiding this comment.
If message is already a string, no need for ``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I DON'T have JIRA ticket
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: