Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added tools to QC to check whether objects is mergeable #13472

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

added tools to QC to check whether objects is mergeable #13472

wants to merge 2 commits into from
+91 −2

Conversation

justonedev1
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

knopers8
knopers8 reviewed Sep 4, 2024
View reviewed changes
Utilities/Mergers/include/Mergers/Mergeable.h Outdated

// \brief Concept to be used to test if some parameter is mergeable
//
// \parameter Ignore can disable whole concept, if user is really sure that he wants to pass anything into this
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obsolete comment

@alibuild
Copy link
Collaborator

alibuild commented Sep 7, 2024 •
edited
Loading

Error while checking build/O2/fullCI for e8bc3ca at 2024-09-25 14:46:

## sw/BUILD/Rivet-latest/log
make[2]: *** [Makefile:544: core.cpp] Error 127
make[1]: *** [Makefile:440: all-recursive] Error 1
make: *** [Makefile:561: all-recursive] Error 1

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Barthelemy Barthelemy Awaiting requested review from Barthelemy Barthelemy is a code owner

@knopers8 knopers8 Awaiting requested review from knopers8 knopers8 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justonedev1 @alibuild @knopers8