Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to CircleCI 2 #60

Merged
merged 5 commits into from
Jul 14, 2018
Merged

Upgrade to CircleCI 2 #60

merged 5 commits into from
Jul 14, 2018

Conversation

djbe
Copy link
Collaborator

@djbe djbe commented Jul 13, 2018

Fixes #59.

I noticed that there's a SPM Package.swift, but CI isn't testing it. Is it up-to-date and should I add it?

@AliSoftware
Copy link
Owner

I have no clue as if it's up to date so one more reason to add it to CI!

@djbe
Copy link
Collaborator Author

djbe commented Jul 13, 2018

Just tried swift build, it's completely broken, doesn't even find UIKit...

I'm going to add the CircleCI job, but not add it to the workflow. I'll leave the SPM implementation for a separate PR.

@djbe
Copy link
Collaborator Author

djbe commented Jul 13, 2018

SPM doesn't support iOS builds yet (can't depend on UIKit). So I've updated the Package.swift file to the new format, and added a notice that it doesn't work yet.

@AliSoftware AliSoftware merged commit 406165f into master Jul 14, 2018
@AliSoftware AliSoftware deleted the feature/circleci2 branch July 14, 2018 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants