Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to swift 4 #54

Merged
merged 5 commits into from
Mar 15, 2018
Merged

Update to swift 4 #54

merged 5 commits into from
Mar 15, 2018

Conversation

AYastrebov
Copy link
Contributor

  • update to swift 4
  • carthage support for swift 4

@AliSoftware
Copy link
Owner

Hey @AYastrebov thanks for this PR, looks good to me 👌

Could you just add an entry in the CHANGELOG.md (under the "# Master" entry) to credit yourself?

(Just format them the same as the previous entries — just don't forget to add two spaces at the end of the line after the ending period . , for Markdown formatting to render as intended)

Copy link
Owner

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Could you also update the README.md?

    • change the "Requirements" section to add Swift 4 to supported versions
    • edit the shields.io' Badge used just above that # Requirements title, to change it to something like [![Language: Swift 3 & 4](https://img.shields.io/badge/Swift-3%20%26%204-orange.svg)](https://swift.org): Language: Swift 3 & 4
  • Also please add an entry to the CHANGELOG.md to credit yourself 👍

Thanks!

@AYastrebov
Copy link
Contributor Author

@AliSoftware sure, will make it asap

@AYastrebov
Copy link
Contributor Author

I've updated the PR. Also pushed a new tag 4.0.2 and updated podSpec.

@AliSoftware
Copy link
Owner

Cool thanks, I'll try to merge & do a release in the afternoon 👍

@AliSoftware AliSoftware merged commit 0638ee4 into AliSoftware:master Mar 15, 2018
@AliSoftware
Copy link
Owner

--------------------------------------------------------------------------------
 🎉  Congrats

 🚀  Reusable (4.0.2) successfully published
 📅  March 15th, 16:13
 🌎  https://cocoapods.org/pods/Reusable
 👍  Tell your friends!
--------------------------------------------------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants