-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to swift 4 #54
Conversation
AYastrebov
commented
Mar 11, 2018
- update to swift 4
- carthage support for swift 4
Hey @AYastrebov thanks for this PR, looks good to me 👌 Could you just add an entry in the (Just format them the same as the previous entries — just don't forget to add two spaces at the end of the line after the ending period |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Could you also update the
README.md
? -
Also please add an entry to the
CHANGELOG.md
to credit yourself 👍
Thanks!
@AliSoftware sure, will make it asap |
I've updated the PR. Also pushed a new tag |
Cool thanks, I'll try to merge & do a release in the afternoon 👍 |
|