Fixed instantiating ViewController basing on StoryboardSceneBased #38
Conversation
ghost
mentioned this pull request
There was a problem hiding this comment.
Could you please add an entry in the CHANGELOG to mention the fix and credit yourself? Thanks!
* Fix `instantiate()` implementation on `StoryboardSceneBased` ViewControllers.
[@jakubgert](https://github.com/jakubgert)
[#38](https://github.com/AliSoftware/Reusable/pull/38)
|
Sure. Should I bump version in CHANGELOG to e.g. 3.0.1 or you will do it? |
|
I usually ask people to add their changelog entry under a But that being said… tbh I think I'll do the release immediately after I merge this PR (cause this is a pretty big and blocking bug), so you can immediately name that new section |
Added description about fix Bumped version
|
🤔 I've had to restart the Travis-CI build 3 times because each time it errors (it doesn't launch the job and fail, no, it just errors without even launching the build…). Let's hope this time it gets better. I have no idea if that's linked to the shortage that Travis-CI is currently experiencing with OSX jobs or not, so if we should change something to make it build again or not, I'm a bit confused… (we have the same problem with #37) |
|
Ok, I bail, I have no f* idea why Travis errors without even starting the build. Merging anyway. |
No description provided.