Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XIB's File's Owner enhancement #16

Merged
merged 4 commits into from
Jun 2, 2016
Merged

Add XIB's File's Owner enhancement #16

merged 4 commits into from
Jun 2, 2016

Conversation

PoissonBallon
Copy link

@PoissonBallon PoissonBallon commented May 30, 2016

I added a NibOwnLoadable Protocol for UIView in Xib's File's Owner
I am available if needed change something,

Thx

@AliSoftware
Copy link
Owner

👍 Will look at it soon

Don't forget to add an entry to the CHANGELOG.md to credit your change though

Also, I think a name like NibOwnerLoadable would fit better than NibOwnLoadable?

@PoissonBallon
Copy link
Author

Done :)

@@ -1,5 +1,8 @@
# CHANGELOG

## 2.2.2
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To respect semantic versioning, it's not gonna be 2.2.2 but 2.3.0 as it is not a bug fix release but adds new APIs.

(Also pls add newline after markdown section title)

@AliSoftware AliSoftware merged commit 03922f2 into AliSoftware:master Jun 2, 2016
AliSoftware added a commit that referenced this pull request Jun 2, 2016
@AliSoftware
Copy link
Owner

It's live! 🎉

Thanks again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants