Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace T with argument of Type #13

Merged
merged 2 commits into from
Mar 1, 2016
Merged

Conversation

narirou
Copy link
Contributor

@narirou narirou commented Feb 29, 2016

Fixed #12
It replaces T with cellType(viewType) because T is a reference to the superclass of cellType.

If you find my mistake, close this PR.
Thanks.

@AliSoftware
Copy link
Owner

Thanks for the PR!

I'm a bit surprised as I thought https://github.com/AliSoftware/Reusable/pull/11/files already addressed that issue. Will take a look at this in details this week!

@AliSoftware
Copy link
Owner

Ok I see now, #11 only changed it in dequeue… methods but not in register…, gotcha!

Well spotted sir, will merge tonight once at home!

AliSoftware added a commit that referenced this pull request Mar 1, 2016
Replace T with argument of Type
@AliSoftware AliSoftware merged commit fe41c44 into AliSoftware:master Mar 1, 2016
@AliSoftware
Copy link
Owner

Version 2.2.1 is now available on CocoaPods!

Thanks again for the Pull Request 👍

@narirou
Copy link
Contributor Author

narirou commented Mar 2, 2016

Thank you for updating. :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inherited class behavior
3 participants