Remove whitespace from empty lines in the test classes #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx! |
|
Time. Leave this open and I'll get to it this week 🙏 ?? |
|
Haha sure, no rush! 👍 |
|
ok, I got to it. 🧀 😁 |
AliSoftware
reviewed
May 24, 2017
| @@ -75,7 +75,7 @@ NS_ASSUME_NONNULL_BEGIN | |||
|
|
|||
| /** | |||
| Creates and returns a network reachability manager with the default socket address. | |||
|
|
|||
There was a problem hiding this comment.
Careful, we shouldn't modify the code of third-party pods 😉
Maybe re-run pod install after your regex to overwrite the pods's code back to their original code for example
There was a problem hiding this comment.
That's what I get for trying to do this fast. 👎
|
Instead of adding a new commit, I amended the last one. I hope that is OK with the github workflow. |
|
Perfect 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Remove unnecessary whitespace from empty lines in the test classes.
Motivation and Context
Future merge issues. Adheres to the already high standard of OHHTTPStubs
Ran all of the tests. 100% passing.