[ACS-7577] [ADF] Remove Folder Directives from Content Services lib #9582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaryaBalvanovich
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
DenysVuika
approved these changes
Apr 22, 2024
DenysVuika
reviewed
Apr 23, 2024
| <button | ||
| data-automation-id="create-new-folder" | ||
| mat-icon-button | ||
| [disabled]="!canCreateContent(documentList.folderNode)" |
There was a problem hiding this comment.
can you please also check if this function no longer used, and remove it as well if it's a dead code
There was a problem hiding this comment.
I returned this button because it is used in tests
DenysVuika
approved these changes
Apr 23, 2024
added 11 commits
April 24, 2024 00:00
This reverts commit a0055aa.
DaryaBalvanovich
force-pushed
the
ACS-7577-remove-folder-directives-from-content-services-lib
branch
from
d0c3637 to
233f40d
Compare
|
DaryaBalvanovich
requested review from
tomson7777,
MichalKinas,
AleksanderSklorz and
tamaragruszka
DenysVuika
approved these changes
Apr 25, 2024
AleksanderSklorz
approved these changes
Apr 29, 2024
DaryaBalvanovich
deleted the
ACS-7577-remove-folder-directives-from-content-services-lib
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Deprecated directives in the project
What is the new behaviour?
Deprecated directives was moved to demo-shell only
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: