[ACS-7688] Reduce the usage of LogService and TranslateModule (tests) #9567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenysVuika
changed the title
DenysVuika
force-pushed
the
log-service-cleanup
branch
from
a5036d8 to
0ff27a5
Compare
DenysVuika
force-pushed
the
log-service-cleanup
branch
from
0ff27a5 to
3a26f3a
Compare
nikita-web-ua
approved these changes
Apr 19, 2024
MichalKinas
reviewed
Apr 19, 2024
...ices-cloud/src/lib/form/components/widgets/attach-file/attach-file-cloud-widget.component.ts
Show resolved
Hide resolved
...process-services-cloud/src/lib/process/start-process/services/start-process-cloud.service.ts
Show resolved
Hide resolved
lib/process-services/src/lib/form/widgets/dynamic-table/dynamic-table.widget.ts
Show resolved
Hide resolved
lib/process-services/src/lib/people/components/people/people.component.ts
Show resolved
Hide resolved
|
MichalKinas
approved these changes
Apr 19, 2024
g-jaskowski
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
TranslateModule.forRoot()calls from unit tests that already haveCoreTestingModuleimportedDoes this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
ACS-7688