Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-7365] Optimise Search providers and unit tests #9477

Merged
merged 10 commits into from
Mar 27, 2024

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented Mar 26, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • remove anti-pattern of making public services for the sake of unit testing
  • remove the need of SEARCH_QUERY_SERVICE_TOKEN inside the Node Selector component
  • remove public accessor workaround from the Node Selector component
  • update unit tests not to rely on public component services
  • fix issues with injections, do not mark base abstract class as Injectable to avoid problems
  • proper setup of the TranslateModule for unit tests, cleanup useless imports

Notes: SEARCH_QUERY_SERVICE_TOKEN is no longer used outside the Content Services library, and can be safely removed

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
JIRA: ACS-7365

@DenysVuika DenysVuika changed the title Optimise Node Selector providers and tests Optimise Search providers and unit tests Mar 26, 2024
@DenysVuika DenysVuika changed the title Optimise Search providers and unit tests [ACS-7365] Optimise Search providers and unit tests Mar 26, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@DenysVuika DenysVuika merged commit f66342d into develop Mar 27, 2024
32 of 33 checks passed
@DenysVuika DenysVuika deleted the fix-search-query-builder branch March 27, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants