[AAE-20769] Fix precision for incoming values in bigdecimal field #9434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BSekula
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
DudaRobert
approved these changes
Mar 15, 2024
| }); | ||
| }); | ||
|
|
||
| it('should return field with proepr precisison', () => { |
There was a problem hiding this comment.
Suggested change
| it('should return field with proepr precisison', () => { | |
| it('should return field with proper precisison', () => { |
| expect(parsedField.value).toBe('10.104'); | ||
| }); | ||
|
|
||
| it('should NOT round up number', () => { |
There was a problem hiding this comment.
Suggested change
| it('should NOT round up number', () => { | |
| it('should NOT round up number, when removed fraction part starts with number smaller than 5 ', () => { |
| expect(parsedField.value).toBe('10.104'); | ||
| }); | ||
|
|
||
| it('should round up number, when removed fraction part starts with number 5 ', () => { |
There was a problem hiding this comment.
Suggested change
| it('should round up number, when removed fraction part starts with number 5 ', () => { | |
| it('should round up number, when removed fraction part starts with number larger than 4 ', () => { |
There was a problem hiding this comment.
changed to when removed fraction part starts with number larger or equal 5
Want to emphasis the boundary, which is 5 here :)
BSekula
force-pushed
the
dev-bsekula-AAE-20769-default-precision-fix
branch
from
23c6014 to
7daa5ae
Compare
BSekula
force-pushed
the
dev-bsekula-AAE-20769-default-precision-fix
branch
from
7daa5ae to
5f4a28a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: