Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADF-5543] Enable lint accessibility and resolve found issues #9421

Merged
merged 12 commits into from
Apr 17, 2024
Merged

[ADF-5543] Enable lint accessibility and resolve found issues #9421

merged 12 commits into from
Apr 17, 2024

Conversation

tomson7777
Copy link
Contributor

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Accessibility issues exist.

What is the new behaviour?
No more accessibility errors.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@AleksanderSklorz
Copy link
Contributor

@tomson7777 please correct PR title with our convention
image

@AleksanderSklorz
Copy link
Contributor

@tomson7777 sonarcloud found some issues, please fix them:
image

@tomson7777 tomson7777 changed the title Adf 5543 enable lint accessibility [ADF-5543] Enable lint accessibility and resolve found issues Mar 18, 2024
@AleksanderSklorz
Copy link
Contributor

@tomson7777 sonarcloud found some issues, please fix them: image

@tomson7777 there are still 3 detected issues, can you have a look and fix them?
image

@tomson7777 tomson7777 force-pushed the ADF-5543-enable-lint-accessibility branch from 29a2482 to 6143fab Compare March 19, 2024 11:44
@tomson7777 tomson7777 force-pushed the ADF-5543-enable-lint-accessibility branch from 60a48fb to a06a3f7 Compare April 11, 2024 11:27
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tomson7777 tomson7777 merged commit 74ef7ee into develop Apr 17, 2024
33 checks passed
@tomson7777 tomson7777 deleted the ADF-5543-enable-lint-accessibility branch April 17, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalKinas MichalKinas MichalKinas approved these changes

@eromano eromano Awaiting requested review from eromano eromano is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

@DenysVuika DenysVuika Awaiting requested review from DenysVuika DenysVuika is a code owner

@AleksanderSklorz AleksanderSklorz Awaiting requested review from AleksanderSklorz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tomson7777 @CLAassistant @AleksanderSklorz @MichalKinas @DenysVuika @tomgny