[ACS-5571] Remove unused WebScript component #8752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-jaskowski
requested review from
nikita-web-ua,
swapnil-verma-gl,
MichalKinas and
AleksanderSklorz
g-jaskowski
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
|
|
|
@DenysVuika @g-jaskowski this is a Braking change are you sure? |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@eromano @DenysVuika I checked it as not a breaking change, as it was used only in the demo shell and otherwise had no UI/UX and no use cases in ACA/ADW/ACC. If it's wrong, please let me know and I will edit it. |
g-jaskowski
force-pushed
the
ACS-5571-ADF-Deprecate-the-WebScript-component
branch
3 times, most recently
from
2e9e89e to
2b5ca2c
Compare
g-jaskowski
force-pushed
the
ACS-5571-ADF-Deprecate-the-WebScript-component
branch
from
2b5ca2c to
924e908
Compare
|
dominikiwanekhyland
approved these changes
Apr 12, 2024
DenysVuika
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
JIRA: ACS-5571
What is the new behaviour?
Removed unused component and sidenav label from demoshell.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: