Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-4523] Assigning content to categories #8451

Conversation

MichalKinas
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

Assigning content to categories is impossible from ACA. https://alfresco.atlassian.net/browse/ACS-4523

What is the new behaviour?

There is a new component that allows both create and manage categories, depending on selected mode. Assign mode will be used in ACA to allow assigning content to categories and create mode will be used in control center to allow creating multiple categories.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@AleksanderSklorz
Copy link
Contributor

AleksanderSklorz commented Apr 7, 2023

Not sure if that is only my local issue but when I'm typing something then spinner is not centered horizontally for me. It is centered horizontally in tags

@AleksanderSklorz
Copy link
Contributor

@MichalKinas I see that clicking at + button closes input for Tags if input for tags is already visible. Is that intended change? I think Agnieszka told that we can see both actually because there is no common scrollbar. Can you verify with her?

@AleksanderSklorz
Copy link
Contributor

I think I found a bug. There is no "Create" button as we can't create category during assigning it but there is still possibility to confirm new category by hitting "Enter". You should disable Enter too, not only hide Create button because that causes user can still create categories.

@AleksanderSklorz
Copy link
Contributor

I noticed an issue where when you type something, remove it and type again - you can see some results but after moment they are gone. If there is no matched results then there should not be visible list for moment, there should be just message

Screen.Recording.2023-04-07.at.21.52.28.mov

@AleksanderSklorz
Copy link
Contributor

AleksanderSklorz commented Apr 7, 2023

For tags we were asked to display exact match as first row. For categories it does not work like that because exact match is not in first row. I guess it can be caused because of added path.
image

@AleksanderSklorz
Copy link
Contributor

There is issue saying that category already exists but I guess it does not make sense for ACA as we can't create category?

image

@MichalKinas MichalKinas force-pushed the ACS-4523-adw-aca-viewer-allow-assigning-content-to-categories-basic branch from ff6a67a to 3e73ff7 Compare April 20, 2023 10:13
@MichalKinas MichalKinas force-pushed the ACS-4523-adw-aca-viewer-allow-assigning-content-to-categories-basic branch from 74de802 to 060f318 Compare April 20, 2023 11:46
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MichalKinas MichalKinas merged commit a563dc2 into develop Apr 20, 2023
@MichalKinas MichalKinas deleted the ACS-4523-adw-aca-viewer-allow-assigning-content-to-categories-basic branch April 20, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants