-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS-4523] Assigning content to categories #8451
[ACS-4523] Assigning content to categories #8451
Conversation
...content-services/src/lib/category/categories-management/categories-management.component.html
Outdated
Show resolved
Hide resolved
...content-services/src/lib/category/categories-management/categories-management.component.html
Show resolved
Hide resolved
docs/content-services/components/categories-management.component.md
Outdated
Show resolved
Hide resolved
...content-services/src/lib/category/categories-management/categories-management.component.html
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/category/categories-management/categories-management.component.ts
Outdated
Show resolved
Hide resolved
...tent-services/src/lib/category/categories-management/categories-management.component.spec.ts
Outdated
Show resolved
Hide resolved
...tent-services/src/lib/category/categories-management/categories-management.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/category/services/category.service.ts
Outdated
Show resolved
Hide resolved
Not sure if that is only my local issue but when I'm typing something then spinner is not centered horizontally for me. It is centered horizontally in tags |
@MichalKinas I see that clicking at + button closes input for Tags if input for tags is already visible. Is that intended change? I think Agnieszka told that we can see both actually because there is no common scrollbar. Can you verify with her? |
lib/content-services/src/lib/category/categories-management-mode.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/category/services/category.service.ts
Outdated
Show resolved
Hide resolved
...ervices/src/lib/content-metadata/components/content-metadata/content-metadata.component.scss
Outdated
Show resolved
Hide resolved
...-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.ts
Show resolved
Hide resolved
...-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.ts
Show resolved
Hide resolved
lib/content-services/src/lib/category/categories-management/categories-management.component.ts
Show resolved
Hide resolved
...-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.ts
Outdated
Show resolved
Hide resolved
I think I found a bug. There is no "Create" button as we can't create category during assigning it but there is still possibility to confirm new category by hitting "Enter". You should disable Enter too, not only hide Create button because that causes user can still create categories. |
lib/content-services/src/lib/category/categories-management/categories-management.component.ts
Show resolved
Hide resolved
I noticed an issue where when you type something, remove it and type again - you can see some results but after moment they are gone. If there is no matched results then there should not be visible list for moment, there should be just message Screen.Recording.2023-04-07.at.21.52.28.mov |
ff6a67a
to
3e73ff7
Compare
74de802
to
060f318
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Assigning content to categories is impossible from ACA. https://alfresco.atlassian.net/browse/ACS-4523
What is the new behaviour?
There is a new component that allows both create and manage categories, depending on selected mode. Assign mode will be used in ACA to allow assigning content to categories and create mode will be used in control center to allow creating multiple categories.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: