[ACS-4294] Added title to clear button and changed its icon type to clear from close #8270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arohilaGL
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
eromano
approved these changes
Feb 15, 2023
MichalKinas
reviewed
Feb 15, 2023
...tent-services/src/lib/search/components/search-facet-field/search-facet-field.component.html
Show resolved
Hide resolved
MichalKinas
reviewed
Feb 15, 2023
...tent-services/src/lib/search/components/search-facet-field/search-facet-field.component.html
Outdated
Show resolved
Hide resolved
MichalKinas
approved these changes
Feb 16, 2023
DenysVuika
changed the title
DenysVuika
approved these changes
Feb 20, 2023
arohilaGL
force-pushed
the
dev-arohila-ACS-4294
branch
from
d65c38f to
0600010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
The button did not have a title or label. Also the button is a clear button but was using close icon.
https://axeauditor.dequecloud.com/api/v1/file/11e4953e-f084-11ec-a1f5-8b0d8917280e
https://alfresco.atlassian.net/browse/ACS-4294
What is the new behaviour?
The button now has a title and the icon has also been changed to clear.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: