[ACS-4411] updateTag method added to tags service #8200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-web-ua
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
MichalKinas
approved these changes
Jan 27, 2023
AleksanderSklorz
approved these changes
Jan 27, 2023
DenysVuika
reviewed
Jan 27, 2023
| })); | ||
|
|
||
| it('should call error on logService when error occurs during tag update', fakeAsync(() => { | ||
| const logService: LogService = TestBed.inject(LogService); |
There was a problem hiding this comment.
for the future, you don't need to specify the type as TestBed.inject was made generic for that reason
DenysVuika
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Currently in ADF there is no method allowing to update tags.
What is the new behaviour?
updateTag() method added to tags service
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://alfresco.atlassian.net/browse/ACS-4411