[AAE-10214] Storybook ErrorContent Component #7761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
marcol13
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
marcol13
requested review from
tomgny,
mauriziovitale,
MichalFidor,
alep85,
andrea-ligios,
erdemedeiros and
gicappa
marcol13
force-pushed
the
dev-mkrueger-AAE-10214
branch
from
a3199e6 to
517e3fa
Compare
tomgny
reviewed
Aug 16, 2022
lib/core/templates/error-content/error-content.component.stories.ts
Outdated
Show resolved
Hide resolved
tomgny
reviewed
Aug 16, 2022
lib/core/templates/error-content/error-content.component.stories.ts
Outdated
Show resolved
Hide resolved
tomgny
reviewed
Aug 16, 2022
lib/core/templates/error-content/error-content.component.stories.ts
Outdated
Show resolved
Hide resolved
marcol13
force-pushed
the
dev-mkrueger-AAE-10214
branch
from
517e3fa to
8ae25ce
Compare
tomgny
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Added three stories for ErrorContent Component:
Handle input codeError changes
Shows known error caused by Route (500 error)
Shows unknown error caused by Route (200 error)
Video:
Screenshare.-.2022-08-10.2_23_13.PM.mp4
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: