[AAE-10220] Storybook stories for Info Drawer component #7757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomgny
reviewed
Aug 17, 2022
| label1: 'Activity', | ||
| label2: 'Details', | ||
| label3: 'More Info', | ||
| tab1Text: `This is a variant of the Info Drawer Layout component that displays information in tabs. Lorem ipsum dolor sit amet, consectetur adipiscing elit. Etiam urna odio, sagittis vel nulla vel, condimentum egestas dolor. |
There was a problem hiding this comment.
can we move those long texts to file with mocks to avoid duplications? i suggest to create mock folder inside info-drawer, and inside it create a mock file.
added 2 commits
August 17, 2022 13:36
…eated mock content
…justed naming convention in comments component
Venrofi
force-pushed
the
dev-terelak-AAE-10220
branch
from
416b440 to
c2ff9c3
Compare
Venrofi
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
tomgny
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: