[ADF-5432] component template and code fixes after testing Angular strict mode #7118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhrn
approved these changes
Jun 22, 2021
| data-automation-id="app-group-app-input"/> | ||
| </mat-form-field> | ||
| <mat-form-field class="app-preselect-value-full"> | ||
| <mat-label>Preselect: {{ DEFAULT_GROUP_PLACEHOLDER }}</mat-label> | ||
| <input matInput | ||
| (input)="setGroupsPreselectValue($event.target?.value)" | ||
| (input)="setGroupsPreselectValue($any($event).target?.value)" |
There was a problem hiding this comment.
is this the recommended way?
There was a problem hiding this comment.
Yeah, it is a suggested way to address untyped events, like DOM ones, see https://angular.io/guide/template-typecheck#disabling-type-checking-using-any
There was a problem hiding this comment.
other way would be type casting in the event handler function
mauriziovitale
approved these changes
Jun 22, 2021
DenysVuika
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Enable strict mode for the component templates (Angular compiler)
multiple fixes for the issues found when enabling the
strictTemplatescompilation option with Angular.those are the small portion of fixes, more changes will be needed to enable the strict mode permanently
(note that with Angular 12 this mode is on by default).
For more details please check:
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://alfresco.atlassian.net/browse/ADF-5432