Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADF-5417] Support multiple search configuration in app config json #7096

Merged
merged 8 commits into from
Jun 15, 2021
Merged

[ADF-5417] Support multiple search configuration in app config json #7096

merged 8 commits into from
Jun 15, 2021

Conversation

dhrn
Copy link
Contributor

@dhrn dhrn commented Jun 7, 2021 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://alfresco.atlassian.net/browse/ADF-5417

What is the new behaviour?

|
mulitpl-search

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@pr-triage pr-triage bot added the PR: draft label Jun 7, 2021
@dhrn dhrn requested review from VitoAlbano, eromano and DenysVuika June 7, 2021 11:43
@dhrn dhrn marked this pull request as ready for review June 8, 2021 05:48
@dhrn dhrn requested a review from popovicsandras as a code owner June 8, 2021 05:48
@dhrn dhrn force-pushed the dev-dhrn-ACS-1642 branch from f204d8b to 3bc6981 Compare June 8, 2021 06:05
@dhrn dhrn changed the title [ACS-1642] Support multiple search configuration in app config json [ADF-5417] Support multiple search configuration in app config json Jun 8, 2021
@dhrn dhrn force-pushed the dev-dhrn-ACS-1642 branch from 3bc6981 to 41c28eb Compare June 10, 2021 08:09
@dhrn dhrn mentioned this pull request Jun 10, 2021
Merged
@dhrn dhrn force-pushed the dev-dhrn-ACS-1642 branch from dbbc4ef to 9a8650c Compare June 10, 2021 13:14
@dhrn dhrn force-pushed the dev-dhrn-ACS-1642 branch 2 times, most recently from f39fb65 to 93ed9ac Compare June 14, 2021 05:50
@dhrn
Copy link
Contributor Author

dhrn commented Jun 15, 2021

/rebase

@github-actions github-actions bot force-pushed the dev-dhrn-ACS-1642 branch from 93ed9ac to bc7dd43 Compare June 15, 2021 05:37
@eromano eromano merged commit ba03c60 into develop Jun 15, 2021
@eromano eromano deleted the dev-dhrn-ACS-1642 branch June 15, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eromano eromano eromano approved these changes

@VitoAlbano VitoAlbano Awaiting requested review from VitoAlbano

@DenysVuika DenysVuika Awaiting requested review from DenysVuika DenysVuika is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhrn @eromano