Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5406] SCSS and HTML template path fixes #7063

Merged
merged 11 commits into from
Jun 1, 2021
Merged

[ADF-5406] SCSS and HTML template path fixes #7063

merged 11 commits into from
Jun 1, 2021

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented May 26, 2021

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Important: This is a prerequisite for Angular 11/12 upgrade, it reduces the amount of efforts needed for upgrade

  • fix issues the templateUrl paths
  • fix issues with the double scss bundling (mixins)
  • reduce useless mixins where possible
  • reduce $mat-small and $mat-xsmall (deprecated/removed in Angular 12)

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/ADF-5406

Copy link
Contributor

@pmartinezga pmartinezga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok having this empty file demo-shell/src/app/components/cloud/start-process-cloud-demo.component.scss?

Copy link
Contributor

@pmartinezga pmartinezga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty demo-shell/src/app/components/cloud/start-task-cloud-demo.component.scss?

@DenysVuika
Copy link
Contributor Author

@pmartinezga empty css files is considered an anti-pattern from what I recall, and puts some pressure on the compile time

@dhrn
Copy link
Contributor

dhrn commented May 31, 2021

/rebase

@DenysVuika DenysVuika merged commit e94b2f9 into develop Jun 1, 2021
@DenysVuika DenysVuika deleted the scss-fixes branch June 1, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants