-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADF-5406] SCSS and HTML template path fixes #7063
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok having this empty file demo-shell/src/app/components/cloud/start-process-cloud-demo.component.scss?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty demo-shell/src/app/components/cloud/start-task-cloud-demo.component.scss?
@pmartinezga empty css files is considered an anti-pattern from what I recall, and puts some pressure on the compile time |
/rebase |
3837864
to
77c6fd1
Compare
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Important: This is a prerequisite for Angular 11/12 upgrade, it reduces the amount of efforts needed for upgrade
templateUrl
paths$mat-small
and$mat-xsmall
(deprecated/removed in Angular 12)Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://alfresco.atlassian.net/browse/ADF-5406