Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-1526] Fail on Draft and unapproved PRs #6963

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

popovicsandras
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the new behaviour?
See https://alfresco.atlassian.net/browse/ACS-1526

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@pr-triage pr-triage bot added the PR: draft label Apr 28, 2021
@popovicsandras popovicsandras marked this pull request as ready for review April 28, 2021 13:09
@popovicsandras popovicsandras force-pushed the dev-apopovics-ACS-1526 branch from b1f4e6a to ecb69c7 Compare April 28, 2021 13:21
Copy link
Contributor

@arditdomi arditdomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big Bang? 🤣

@popovicsandras popovicsandras merged commit c0b5935 into develop Apr 28, 2021
@popovicsandras popovicsandras deleted the dev-apopovics-ACS-1526 branch April 28, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants