-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACA-4389] [APS1] Convert some of process services extension E2E steps to unit-tests #6959
Conversation
lib/process-services/src/lib/task-list/components/task-filters.component.spec.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, it is great to see e2e becoming unit tests. I suggested some changes to the names. Please give them a look 🙂
lib/process-services/src/lib/task-list/components/task-form/task-form.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/process-services/src/lib/task-list/components/task-form/task-form.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/process-services/src/lib/task-list/components/task-form/task-form.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/process-services/src/lib/task-list/components/task-form/task-form.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/process-services/src/lib/task-list/components/task-form/task-form.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/process-services/src/lib/task-list/components/task-form/task-form.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/process-services/src/lib/task-list/components/task-form/task-form.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/process-services/src/lib/task-list/components/task-form/task-form.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/process-services/src/lib/task-list/components/task-form/task-form.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/process-services/src/lib/task-list/components/task-form/task-form.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/process-services/src/lib/task-list/components/task-form/task-form.component.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the consecutive reviews 🙁 just noticed them
lib/process-services/src/lib/task-list/components/task-filters.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/process-services/src/lib/task-list/components/task-form/task-form.component.spec.ts
Show resolved
Hide resolved
714bad3
to
37b9ede
Compare
37b9ede
to
9439f35
Compare
9439f35
to
11fc36f
Compare
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACA-4389
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: