[AAE-4985] - Make SSO Role Service accept a content admin role that is not part of the JWT token #6942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arditdomi
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
arditdomi
requested review from
sivakumar414ram,
mauriziovitale and
andrea-ligios
arditdomi
changed the title
eromano
requested changes
Apr 23, 2021
mauriziovitale
approved these changes
Apr 23, 2021
pr-triage
bot
added
PR: partially-approved
PR: unreviewed
and removed
PR: unreviewed
PR: partially-approved
labels
arditdomi
force-pushed
the
dev-adomi-AAE-4985-sso-role-service
branch
from
496c78b to
794f1b3
Compare
eromano
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/AAE-4985
What is the new behaviour?
In a new feature, there is the need of checking if the logged in user is an ACS Admin user or not using this service. This information can not become part of the JWT token right now, which means we need to call an ACS API to check that inside this service as it currently completely relies on the JWT token. With the new behaviour it will make an API call to check that the user is an ACS Admin or not, when in the roles array we have the ALFRESCO_ADMINISTRATORS included.
Example:
router.data = { 'roles': ['ALFRESCO_ADMINISTRATORS'] };Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: