Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-4483] Add empty list drag and drop template in upload from local… #6916

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

arditdomi
Copy link
Contributor

… tab

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/AAE-4483

What is the new behaviour?
Screenshot 2021-04-09 at 5 12 22 pm

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Copy link
Contributor

@eromano eromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this already be the default empty of the documentlist?

@arditdomi
Copy link
Contributor Author

arditdomi commented Apr 9, 2021

should this already be the default empty of the documentlist?

The document list is in the first tab.
In the second tab we have the file-uploading-dialog component which before uploading something looks like this with all this empty space
Screenshot 2021-04-09 at 5 19 36 pm

and after uploading looks like this

Screenshot 2021-04-09 at 5 19 56 pm

@eromano eromano merged commit 291e224 into develop Apr 12, 2021
@eromano eromano deleted the dev-adomi-AAE-4483 branch April 12, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants