Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved language picker #6890

Merged
merged 3 commits into from
Apr 6, 2021
Merged

improved language picker #6890

merged 3 commits into from
Apr 6, 2021

Conversation

DenysVuika
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • migrate language picker button from ACA to ADF
  • introduce new Language Service to reduce the logic from the language button/menu components
  • simplify the language components
  • provide defaults for language service as the officially supported languages
  • remove custom languages list from app.config.json as it's based on official defaults (reduces the json size)

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Mar 31, 2021

Codecov Report

Merging #6890 (95e9cde) into develop (37b10ec) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6890      +/-   ##
===========================================
+ Coverage    76.51%   76.57%   +0.05%     
===========================================
  Files          885      878       -7     
  Lines        20219    19957     -262     
  Branches      4030     3959      -71     
===========================================
- Hits         15471    15282     -189     
+ Misses        3509     3456      -53     
+ Partials      1239     1219      -20     
Impacted Files Coverage Δ
lib/core/language-menu/language-menu.module.ts 100.00% <ø> (ø)
lib/core/services/user-preferences.service.ts 87.50% <ø> (ø)
lib/core/language-menu/language-menu.component.ts 100.00% <100.00%> (ø)
...ib/core/language-menu/language-picker.component.ts 100.00% <100.00%> (ø)
lib/core/services/language.service.ts 100.00% <100.00%> (ø)
lib/core/services/translate-loader.service.ts 66.12% <0.00%> (-9.68%) ⬇️
...src/lib/document-list/data/share-data-row.model.ts 73.68% <0.00%> (-2.64%) ⬇️
lib/extensions/src/lib/config/extension-utils.ts
...b/extensions/src/lib/evaluators/core.evaluators.ts
lib/extensions/src/test.ts
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37b10ec...95e9cde. Read the comment docs.

@eromano eromano merged commit 145c053 into develop Apr 6, 2021
@eromano eromano deleted the lang-button branch April 6, 2021 09:35
TomikaArome pushed a commit that referenced this pull request Apr 9, 2021
* improved language picker

* fix import path

* update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants