Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update js-api #6847

Merged
merged 12 commits into from
Mar 26, 2021
Merged

update js-api #6847

merged 12 commits into from
Mar 26, 2021

Conversation

eromano
Copy link
Contributor

@eromano eromano commented Mar 23, 2021

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Mar 23, 2021

Codecov Report

Merging #6847 (b68d7fb) into develop (ab6354d) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head b68d7fb differs from pull request most recent head 7c16a4e. Consider uploading reports for the commit 7c16a4e to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6847      +/-   ##
===========================================
- Coverage    76.39%   76.38%   -0.01%     
===========================================
  Files          883      883              
  Lines        20088    20100      +12     
  Branches      4003     4006       +3     
===========================================
+ Hits         15346    15354       +8     
- Misses        3515     3519       +4     
  Partials      1227     1227              
Impacted Files Coverage Δ
...rm/services/content-cloud-node-selector.service.ts 27.77% <0.00%> (-5.56%) ⬇️
...rc/lib/form/mocks/attach-file-cloud-widget.mock.ts 100.00% <0.00%> (ø)
.../attach-file/attach-file-cloud-widget.component.ts 84.26% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6354d...7c16a4e. Read the comment docs.

@CLAassistant
Copy link

CLAassistant commented Mar 23, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ eromano
❌ Travis CI User


Travis CI User seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@eromano eromano merged commit 0e673a9 into develop Mar 26, 2021
@eromano eromano deleted the update-js-api branch March 26, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants