[ACA-4202] - forcing firefox to ignore cache when document version ha… #6807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitoAlbano
requested review from
DenysVuika,
eromano and
popovicsandras
as code owners
eromano
reviewed
Mar 23, 2021
| @@ -212,6 +212,7 @@ <h2>{{ 'ADF_VIEWER.LOADING' | translate }}</h2> | |||
| [blobFile]="blobFile" | |||
| [urlFile]="urlFileContent" | |||
| [nameFile]="displayName" | |||
| [cacheType]="cacheTypeForContent" | |||
There was a problem hiding this comment.
do we need a new input? or we can add it always?
There was a problem hiding this comment.
Due the fact that this affects the caching for when we get the file it might be better to have a flexible strategy. Maybe the no-cache is something that makes sense for us but not in some other cases when the viewer is used.
VitoAlbano
force-pushed
the
dev-valbano-ACA-4202-firefox
branch
from
4347975 to
3221f22
Compare
VitoAlbano
force-pushed
the
dev-valbano-ACA-4202-firefox
branch
from
3221f22 to
1fe6e15
Compare
eromano
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s changed
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Only for Firefox whenever the user updates a new version with the same name of a doc document whilst viewing it, the document is not refreshed but it's taken from the FF cache.
What is the new behaviour?
Whenever a new version steps in, we set the header of pdf-js to 'no-cache' and this will force the browser to actual fetch the new version
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://alfresco.atlassian.net/browse/ACA-4202