Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-4306] Testing - Add form widget ids in the SIMPLEAPP resources file #6806

Merged
merged 8 commits into from
Mar 22, 2021

Conversation

arditdomi
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:
    Add widget ids for some forms of simpleapp

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACA-4306

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@arditdomi
Copy link
Contributor Author

/rebase

@github-actions github-actions bot force-pushed the dev-adomi-ACA-4306 branch from f77bf45 to a63db4d Compare March 11, 2021 17:38
@codecov-io
Copy link

codecov-io commented Mar 11, 2021

Codecov Report

Merging #6806 (203f7c1) into develop (3d46976) will increase coverage by 1.04%.
The diff coverage is n/a.

❗ Current head 203f7c1 differs from pull request most recent head 510bc34. Consider uploading reports for the commit 510bc34 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6806      +/-   ##
===========================================
+ Coverage    76.38%   77.42%   +1.04%     
===========================================
  Files          882      156     -726     
  Lines        20086     4341   -15745     
  Branches      4001      854    -3147     
===========================================
- Hits         15342     3361   -11981     
+ Misses        3519      689    -2830     
+ Partials      1225      291     -934     
Impacted Files Coverage Δ
...sk-header/mocks/fake-task-details-response.mock.ts
...c/lib/task-list/components/task-audit.directive.ts
...ons/src/lib/services/component-register.service.ts
lib/core/icon/icon.module.ts
...ces-cloud/src/lib/group/pipe/group-initial.pipe.ts
...c/lib/mock/process/start-process.component.mock.ts
...b/diagram/models/report/report-definition.model.ts
...core/card-view/models/card-view-arrayitem.model.ts
...t/about-github-link/about-github-link.component.ts
...atable/components/json-cell/json-cell.component.ts
... and 716 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d46976...510bc34. Read the comment docs.

@arditdomi
Copy link
Contributor Author

/rebase

@github-actions github-actions bot force-pushed the dev-adomi-ACA-4306 branch from a63db4d to b1ff1c8 Compare March 17, 2021 09:18
@arditdomi
Copy link
Contributor Author

/rebase

@github-actions github-actions bot force-pushed the dev-adomi-ACA-4306 branch from b1ff1c8 to 70b427d Compare March 22, 2021 08:47
@arditdomi arditdomi force-pushed the dev-adomi-ACA-4306 branch from 70b427d to 203f7c1 Compare March 22, 2021 10:40
@arditdomi arditdomi merged commit 2d257ea into develop Mar 22, 2021
@arditdomi arditdomi deleted the dev-adomi-ACA-4306 branch March 22, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants