Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5318] E2E Content Change type #6799

Merged
merged 2 commits into from
Mar 22, 2021
Merged

[ADF-5318] E2E Content Change type #6799

merged 2 commits into from
Mar 22, 2021

Conversation

dhrn
Copy link
Contributor

@dhrn dhrn commented Mar 9, 2021

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:
    Automation

What is the current behaviour? (You can also link to an open issue here)

Automate change type

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Mar 12, 2021

Codecov Report

Merging #6799 (dbb1984) into develop (0a9e8b8) will increase coverage by 1.65%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6799      +/-   ##
===========================================
+ Coverage    76.39%   78.05%   +1.65%     
===========================================
  Files          882      367     -515     
  Lines        20086    10124    -9962     
  Branches      4001     2047    -1954     
===========================================
- Hits         15345     7902    -7443     
+ Misses        3515     1581    -1934     
+ Partials      1226      641     -585     
Impacted Files Coverage Δ
lib/core/services/search.service.ts
...ents/widgets/dynamic-table/dynamic-table.widget.ts
lib/core/services/discovery-api.service.ts
lib/core/models/ecm-user.model.ts
...onents/icons/diagram-icon-script-task.component.ts
.../components/icons/diagram-icon-signal.component.ts
...e/card-view/models/card-view-datetimeitem.model.ts
.../widgets/dynamic-table/editors/date/date.editor.ts
lib/core/mock/app-config.service.mock.ts
lib/core/data-column/data-column-list.component.ts
... and 506 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a9e8b8...dbb1984. Read the comment docs.

@dhrn dhrn requested review from VitoAlbano, DenysVuika and eromano and removed request for VitoAlbano and DenysVuika March 12, 2021 08:16
@dhrn
Copy link
Contributor Author

dhrn commented Mar 22, 2021

/rebase

@github-actions github-actions bot force-pushed the dev-dhrn-ADF-5318 branch from 2a8b7cc to dbb1984 Compare March 22, 2021 05:34
@dhrn dhrn marked this pull request as ready for review March 22, 2021 07:48
@eromano eromano merged commit 8f8819c into develop Mar 22, 2021
@eromano eromano deleted the dev-dhrn-ADF-5318 branch March 22, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants