Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-4661] Fix search results are still displayed when search term ge… #6707

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

arditdomi
Copy link
Contributor

…ts deleted

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/AAE-4661

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Feb 21, 2021

Codecov Report

Merging #6707 (a5d9a6a) into develop (f6308a7) will increase coverage by 2.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6707      +/-   ##
===========================================
+ Coverage    76.39%   78.63%   +2.23%     
===========================================
  Files          882      211     -671     
  Lines        20007     5720   -14287     
  Branches      3965     1161    -2804     
===========================================
- Hits         15285     4498   -10787     
+ Misses        3512      888    -2624     
+ Partials      1210      334     -876     
Impacted Files Coverage Δ
.../content-services/src/lib/dialogs/dialog.module.ts
...s/activities/diagram-box-publish-task.component.ts
...b/core/info-drawer/info-drawer-layout.component.ts
...vices/src/lib/mock/document-list.component.mock.ts
...ectives/custom-no-permission-template.directive.ts
...ns/diagram-icon-alfresco-publish-task.component.ts
lib/core/models/component.model.ts
...ib/content-services/src/lib/audit/audit.service.ts
lib/insights/src/lib/diagram/diagram.module.ts
...templates/error-content/error-content.component.ts
... and 661 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6308a7...a5d9a6a. Read the comment docs.

@arditdomi arditdomi merged commit 4a54e85 into develop Feb 22, 2021
@arditdomi arditdomi deleted the dev-adomi-AAE-4661 branch February 22, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants