Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ATS-854] Add media tracks to player from webvtt rendition #6626

Conversation

pmartinezga
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ATS-854

What is the new behaviour?
https://alfresco.atlassian.net/browse/ATS-854

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@pmartinezga pmartinezga force-pushed the dev-pmartinezga-ATS-854-add-medita-tracks-to-player-from-webvtt-rendition branch from b6a6ff1 to ef88140 Compare February 4, 2021 10:31
@@ -416,6 +419,10 @@ export class ViewerComponent implements OnChanges, OnInit, OnDestroy {
}
}

if (this.viewerType === 'media') {
this.mediaTracks = await this.viewUtils.generateMediaTracks(nodeData.id);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this thing be in adf-media-player ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do it here or in the media player. I decided to do it here and keep media without any logic to follow the same approach that has been done with the source url, that is not calculated in media player but here in the viewer.

I can do it as you prefer, @eromano media or viewer?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to me looks a media player concern and you are right in this class there are other concern to move

@codecov-io
Copy link

Codecov Report

Merging #6626 (2578de4) into develop (a133678) will increase coverage by 1.90%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6626      +/-   ##
===========================================
+ Coverage    76.26%   78.17%   +1.90%     
===========================================
  Files          871      493     -378     
  Lines        19654    11558    -8096     
  Branches      3917     2200    -1717     
===========================================
- Hits         14990     9035    -5955     
+ Misses        3470     1827    -1643     
+ Partials      1194      696     -498     
Impacted Files Coverage Δ
.../lib/task-list/components/task-header.component.ts 82.97% <0.00%> (-6.50%) ⬇️
.../lib/document-list/data/share-datatable-adapter.ts 69.92% <0.00%> (-2.05%) ⬇️
.../lib/search/search-header-query-builder.service.ts 73.46% <0.00%> (-1.54%) ⬇️
.../attach-file/attach-file-cloud-widget.component.ts 85.52% <0.00%> (-1.15%) ⬇️
...lib/task-list/components/task-details.component.ts 75.42% <0.00%> (-0.85%) ⬇️
...load/components/file-uploading-dialog.component.ts 89.33% <0.00%> (-0.67%) ⬇️
...-selector/content-node-selector-panel.component.ts 85.35% <0.00%> (-0.37%) ⬇️
...ocument-list/components/document-list.component.ts 81.90% <0.00%> (-0.31%) ⬇️
...vices/src/lib/search/base-query-builder.service.ts 84.28% <0.00%> (-0.23%) ⬇️
lib/core/viewer/components/pdf-viewer.component.ts
... and 378 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a133678...f479cb2. Read the comment docs.

@pmartinezga pmartinezga requested a review from eromano February 8, 2021 06:53
@eromano eromano merged commit 5d8d5f5 into develop Feb 8, 2021
@eromano eromano deleted the dev-pmartinezga-ATS-854-add-medita-tracks-to-player-from-webvtt-rendition branch February 8, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants