-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ATS-854] Add media tracks to player from webvtt rendition #6626
[ATS-854] Add media tracks to player from webvtt rendition #6626
Conversation
b6a6ff1
to
ef88140
Compare
@@ -416,6 +419,10 @@ export class ViewerComponent implements OnChanges, OnInit, OnDestroy { | |||
} | |||
} | |||
|
|||
if (this.viewerType === 'media') { | |||
this.mediaTracks = await this.viewUtils.generateMediaTracks(nodeData.id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this thing be in adf-media-player ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do it here or in the media player. I decided to do it here and keep media without any logic to follow the same approach that has been done with the source url, that is not calculated in media player but here in the viewer.
I can do it as you prefer, @eromano media or viewer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to me looks a media player concern and you are right in this class there are other concern to move
Codecov Report
@@ Coverage Diff @@
## develop #6626 +/- ##
===========================================
+ Coverage 76.26% 78.17% +1.90%
===========================================
Files 871 493 -378
Lines 19654 11558 -8096
Branches 3917 2200 -1717
===========================================
- Hits 14990 9035 -5955
+ Misses 3470 1827 -1643
+ Partials 1194 696 -498
Continue to review full report at Codecov.
|
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ATS-854
What is the new behaviour?
https://alfresco.atlassian.net/browse/ATS-854
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: