Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-4553] Improve error logs in scan-env #6608

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Conversation

TomikaArome
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

Non-SSO related errors simply output the entire error object to the terminal.

What is the new behaviour?

Improved output by logging at the beginning of the script and at the beginning of each method to retrieve information, as well as logging a successful SSO connection and filtering the errors to just the relevant information.
image
image

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@eromano
Copy link
Contributor

eromano commented Feb 2, 2021

/rebase

@github-actions github-actions bot force-pushed the dev-thunter-AAE-4553 branch from 9f9811e to 6537822 Compare February 2, 2021 07:47
@eromano eromano merged commit a133678 into develop Feb 3, 2021
@eromano eromano deleted the dev-thunter-AAE-4553 branch February 3, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants