Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the TODO placeholders from the release note. #6442

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

fcorti
Copy link
Contributor

@fcorti fcorti commented Dec 9, 2020

Ok to bring this into the next version of ADF.

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
N/A

What is the new behaviour?
N/A

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
Removed the TODO placeholders from the release note.

Ok to bring this into the next version of ADF.
@fcorti fcorti added this to the 4.3.0 milestone Dec 9, 2020
@codecov-io
Copy link

Codecov Report

Merging #6442 (7e1bf6e) into develop (e2b88dd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6442   +/-   ##
========================================
  Coverage    77.32%   77.32%           
========================================
  Files          147      147           
  Lines         4163     4163           
  Branches       830      830           
========================================
  Hits          3219     3219           
  Misses         668      668           
  Partials       276      276           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b88dd...7e1bf6e. Read the comment docs.

@eromano eromano merged commit 38c10fc into develop Dec 9, 2020
@eromano eromano deleted the fcorti-patch-1 branch December 9, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants