Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-4208] - fix date filter by range #6421

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Conversation

SilviuCPopa
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACA-4208

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Dec 4, 2020

Codecov Report

Merging #6421 (e3f23b5) into develop (786984b) will increase coverage by 1.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6421      +/-   ##
===========================================
+ Coverage    76.28%   77.95%   +1.67%     
===========================================
  Files          870      356     -514     
  Lines        19668     9759    -9909     
  Branches      3912     1968    -1944     
===========================================
- Hits         15004     7608    -7396     
+ Misses        3467     1544    -1923     
+ Partials      1197      607     -590     
Impacted Files Coverage Δ
...k-filters/base-edit-task-filter-cloud.component.ts 72.00% <100.00%> (+0.16%) ⬆️
lib/core/toolbar/toolbar-divider.component.ts
...re/viewer/components/viewer-open-with.component.ts
...core/notifications/helpers/notification.factory.ts
...ets/dynamic-table/required-cell-validator.model.ts
lib/core/toolbar/toolbar.component.ts
lib/extensions/src/lib/config/action.extensions.ts
.../components/widgets/core/container-column.model.ts
lib/core/services/auth-guard.service.ts
lib/core/services/ecm-user.service.ts
... and 505 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 786984b...e3f23b5. Read the comment docs.

@eromano eromano merged commit c3cb1f9 into develop Dec 4, 2020
@eromano eromano deleted the dev-spopa-ACA-4208 branch December 4, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants