Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-2176] prevent Esc click event bubble into the Viewer #6378

Merged
merged 2 commits into from
Dec 2, 2020

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented Nov 24, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • prevent Escape click bubble up to the Viewer component
  • should fix the case when a Node Selector dialog is displayed on top of the Overlay Viewer and user clicks Esc button (right now both of them close)

Notes: the demo shell has no ways testing it, but ACA has a failing e2e test for this

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/ACA-2176

@codecov-io
Copy link

codecov-io commented Nov 24, 2020

Codecov Report

Merging #6378 (7605700) into develop (567ea6c) will increase coverage by 0.14%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6378      +/-   ##
===========================================
+ Coverage    76.33%   76.48%   +0.14%     
===========================================
  Files          871      861      -10     
  Lines        19652    19392     -260     
  Branches      3896     3828      -68     
===========================================
- Hits         15002    14832     -170     
+ Misses        3468     3393      -75     
+ Partials      1182     1167      -15     
Impacted Files Coverage Δ
lib/core/viewer/components/viewer.component.ts 71.13% <0.00%> (-0.59%) ⬇️
...t-node-selector/content-node-selector.component.ts 64.86% <55.55%> (-4.11%) ⬇️
...ntent-node-selector/content-node-dialog.service.ts 75.86% <100.00%> (ø)
.../lib/task-list/components/attach-form.component.ts 43.58% <0.00%> (-7.70%) ⬇️
...src/lib/document-list/data/share-data-row.model.ts 73.68% <0.00%> (-2.64%) ⬇️
lib/core/services/auth-guard.service.ts 47.36% <0.00%> (-2.64%) ⬇️
...core/directives/version-compatibility.directive.ts 66.66% <0.00%> (ø)
...t-services/src/lib/group/services/group.service.ts
...ons/src/lib/services/component-register.service.ts
lib/extensions/src/lib/config/extension-utils.ts
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 567ea6c...759e77f. Read the comment docs.

@DenysVuika DenysVuika force-pushed the fix-node-selector-close branch from fff759e to 0d8431e Compare November 27, 2020 10:27
@eromano
Copy link
Contributor

eromano commented Nov 29, 2020

/rebase

@github-actions github-actions bot force-pushed the fix-node-selector-close branch from 0d8431e to 7605700 Compare November 29, 2020 21:32
@DenysVuika
Copy link
Contributor Author

/rebase

@github-actions github-actions bot force-pushed the fix-node-selector-close branch from 7605700 to 759e77f Compare December 2, 2020 11:11
@DenysVuika DenysVuika merged commit a3fabf6 into develop Dec 2, 2020
@DenysVuika DenysVuika deleted the fix-node-selector-close branch December 2, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants