Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve env check #6361

Merged
merged 4 commits into from
Nov 20, 2020
Merged

Improve env check #6361

merged 4 commits into from
Nov 20, 2020

Conversation

eromano
Copy link
Contributor

@eromano eromano commented Nov 18, 2020

Please check if the PR fulfills these requirements

  • [ x] The commit message follows our guidelines
  • [ x] Tests for the changes have been added (for bug fixes / features)
  • [x ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • [x ] Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Improve env check

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

codecov-io commented Nov 20, 2020

Codecov Report

Merging #6361 (94f07fa) into develop (20810ec) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6361   +/-   ##
========================================
  Coverage    76.43%   76.43%           
========================================
  Files          871      871           
  Lines        19658    19658           
  Branches      3894     3894           
========================================
  Hits         15026    15026           
  Misses        3457     3457           
  Partials      1175     1175           
Impacted Files Coverage Δ
lib/core/services/thumbnail.service.ts 77.77% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20810ec...94f07fa. Read the comment docs.

@eromano eromano merged commit 49368c7 into develop Nov 20, 2020
@eromano eromano deleted the dev-eromano-improve-env-check branch November 20, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants