Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT-21920] Fix Card View Integers initialization when they are set to 0 #6320

Merged
merged 2 commits into from
Nov 10, 2020

Conversation

davidcanonieto
Copy link
Contributor

@davidcanonieto davidcanonieto commented Nov 5, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/MNT-21920

What is the new behaviour?
When an integer text edit card view was set to 0 the component would understand it as an empty field. This issue has been addresses by improving the way we tell if it's empty or not.

Screen Shot 2020-11-05 at 13 34 35

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Copy link
Contributor

@eromano eromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a unit test?

@codecov-io
Copy link

codecov-io commented Nov 6, 2020

Codecov Report

Merging #6320 (1e7d51a) into develop (0ee08f7) will increase coverage by 1.88%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6320      +/-   ##
===========================================
+ Coverage    76.28%   78.16%   +1.88%     
===========================================
  Files          865      353     -512     
  Lines        19583     9683    -9900     
  Branches      3889     1947    -1942     
===========================================
- Hits         14939     7569    -7370     
+ Misses        3477     1526    -1951     
+ Partials      1167      588     -579     
Impacted Files Coverage Δ
...nts/content-metadata/content-metadata.component.ts 94.02% <100.00%> (+0.09%) ⬆️
...ata/services/property-groups-translator.service.ts 96.29% <100.00%> (+0.06%) ⬆️
...re/viewer/components/pdf-viewer-thumb.component.ts
...b/extensions/src/lib/services/extension.service.ts
...ib/diagram/models/diagram/diagram-element.model.ts
...e/form/components/widgets/core/form-field.model.ts
...m/components/widgets/date-time/date-time.widget.ts
...ib/core/form/services/widget-visibility.service.ts
...-view/validators/card-view-item-length.valiator.ts
lib/core/layout/layout.module.ts
... and 505 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ee08f7...c80e348. Read the comment docs.

@eromano eromano merged commit a9f9e18 into develop Nov 10, 2020
@eromano eromano deleted the dev-dcano-MNT-21920 branch November 10, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants