Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-3966] FE - Disable the upload button when the user doesn't have permissions in a folder #6304

Merged
merged 5 commits into from
Nov 4, 2020

Conversation

sivakumar414ram
Copy link
Contributor

@sivakumar414ram sivakumar414ram commented Nov 3, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://alfresco.atlassian.net/browse/AAE-3966

What is the new behaviour?

ezgif com-gif-maker

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@sivakumar414ram sivakumar414ram force-pushed the dev-sk-AAE-3966-disable-upload-button branch from 1e7b6aa to a7e1b25 Compare November 3, 2020 14:25
@codecov-io
Copy link

codecov-io commented Nov 4, 2020

Codecov Report

Merging #6304 into develop will increase coverage by 1.91%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6304      +/-   ##
===========================================
+ Coverage    76.26%   78.18%   +1.91%     
===========================================
  Files          864      352     -512     
  Lines        19583     9690    -9893     
  Branches      3901     1959    -1942     
===========================================
- Hits         14935     7576    -7359     
+ Misses        3475     1520    -1955     
+ Partials      1173      594     -579     
Impacted Files Coverage Δ
...t-node-selector/content-node-selector.component.ts 73.07% <83.33%> (+4.89%) ⬆️
...-selector/content-node-selector-panel.component.ts 85.56% <100.00%> (+0.23%) ⬆️
lib/core/data-column/data-column.component.ts
lib/core/services/auth-guard.service.ts
lib/core/mock/form/demo-form.mock.ts
...nents/raphael/icons/raphael-icon-mule.component.ts
lib/core/services/deleted-nodes-api.service.ts
...s/activities/diagram-box-publish-task.component.ts
lib/core/datatable/data/object-datarow.model.ts
lib/core/services/discovery-api.service.ts
... and 504 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 456e042...53a372c. Read the comment docs.

@mauriziovitale mauriziovitale merged commit b8cacd3 into develop Nov 4, 2020
@mauriziovitale mauriziovitale deleted the dev-sk-AAE-3966-disable-upload-button branch November 4, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants