[AAE-3967] Add datetime-range search filter component #6297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #6297 +/- ##
===========================================
+ Coverage 76.26% 78.07% +1.81%
===========================================
Files 864 353 -511
Lines 19583 9749 -9834
Branches 3901 1973 -1928
===========================================
- Hits 14935 7612 -7323
+ Misses 3475 1532 -1943
+ Partials 1173 605 -568
Continue to review full report at Codecov.
|
arditdomi
requested review from
DenysVuika,
eromano,
m-hulbert and
popovicsandras
as code owners
eromano
requested changes
Nov 2, 2020
| this.apply(this.form.value, this.form.valid); | ||
| } | ||
|
|
||
| hasValidValue() { |
| return this.form.valid; | ||
| } | ||
|
|
||
| getCurrentValue() { |
| moment.locale(locale); | ||
| } | ||
|
|
||
| hasParseError(formControl) { |
| event.srcElement.click(); | ||
| } | ||
|
|
||
| setFromMaxDatetime(): any { |
...-services/src/lib/search/components/search-datetime-range/search-datetime-range.component.ts
Outdated
Show resolved
Hide resolved
...-services/src/lib/search/components/search-datetime-range/search-datetime-range.component.ts
Outdated
Show resolved
Hide resolved
|
|
||
| const inputs = fixture.debugElement.nativeElement.querySelectorAll('input[ng-reflect-max="Tue Mar 10 2020 20:00:00 GMT+0"]'); | ||
|
|
||
| expect(inputs[0]).toBeDefined(); |
...ent-services/src/lib/search/components/search-date-range/search-date-range.component.spec.ts
Outdated
Show resolved
Hide resolved
| it('should setup form elements on init', () => { | ||
| fixture.detectChanges(); | ||
|
|
||
| expect(component.from).toBeDefined(); |
There was a problem hiding this comment.
is defined in general or should it have a certain value?
cristinaj
reviewed
Nov 3, 2020
| --- | ||
|
|
||
| # [Search datetime range component](../../../lib/content-services/src/lib/search/components/search-datetime-range/search-datetime-range.component.ts "Defined in search-date-range.component.ts") | ||
|
|
There was a problem hiding this comment.
shouldn't be search-datetime-range.component.ts instead of search-date-range.component.ts?
cristinaj
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/AAE-3967
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: