Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACA-4071] [ADW-Cloud]Task header takes too much to be loaded after claiming a task #6294

Merged
merged 3 commits into from
Nov 4, 2020

Conversation

sivakumar414ram
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://issues.alfresco.com/jira/browse/ACA-4071

What is the new behaviour?

task-header-cloud

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Copy link
Contributor

@mauriziovitale mauriziovitale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the comment

@codecov-io
Copy link

codecov-io commented Nov 3, 2020

Codecov Report

Merging #6294 into develop will increase coverage by 1.87%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6294      +/-   ##
===========================================
+ Coverage    76.30%   78.18%   +1.87%     
===========================================
  Files          864      352     -512     
  Lines        19583     9686    -9897     
  Branches      3901     1958    -1943     
===========================================
- Hits         14943     7573    -7370     
+ Misses        3466     1519    -1947     
+ Partials      1174      594     -580     
Impacted Files Coverage Δ
...k-header/components/task-header-cloud.component.ts 85.00% <100.00%> (+0.78%) ⬆️
.../lib/task-list/components/attach-form.component.ts 43.58% <0.00%> (ø)
...omponents/analytics-report-parameters.component.ts
lib/core/services/renditions.service.ts
lib/core/viewer/viewer.module.ts
.../src/lib/diagram/services/diagram-color.service.ts
lib/insights/src/lib/material.module.ts
lib/core/mock/translation.service.mock.ts
lib/core/services/version-compatibility-factory.ts
lib/core/context-menu/animations.ts
... and 504 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39275a0...479edf1. Read the comment docs.

@mauriziovitale mauriziovitale merged commit c676b20 into develop Nov 4, 2020
@mauriziovitale mauriziovitale deleted the dev-sk-ACA-4071 branch November 4, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants