Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AAE-3925] Add support for date type searchable properties in attach … #6274

Merged
merged 2 commits into from
Oct 22, 2020
Merged

[AAE-3925] Add support for date type searchable properties in attach … #6274

merged 2 commits into from
Oct 22, 2020

Conversation

arditdomi
Copy link
Contributor

…file widget

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/AAE-3925

What is the new behaviour?
Date type support has been added
Screenshot 2020-10-22 at 11 44 06 am

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

mauriziovitale
mauriziovitale reviewed Oct 22, 2020
View reviewed changes
lib/content-services/src/lib/content-node-selector/content-node-selector-panel.service.spec.ts Outdated

const contentNodeSelectorPanelService = new ContentNodeSelectorPanelService();

it('should supported types be text and date', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have different tests?

mauriziovitale
mauriziovitale reviewed Oct 22, 2020
View reviewed changes
lib/content-services/src/lib/content-node-selector/content-node-selector-panel.service.ts Outdated
@@ -55,4 +62,8 @@ export class ContentNodeSelectorPanelService {
return filterSearch;
}

isDataTypeSupported(dataType: string): boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isTypeSupported sounds better

mauriziovitale
mauriziovitale requested changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@mauriziovitale mauriziovitale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comments

@codecov-io
Copy link

codecov-io commented Oct 22, 2020 •
edited
Loading

Codecov Report

Merging #6274 into develop will increase coverage by 2.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6274      +/-   ##
===========================================
+ Coverage    76.34%   78.71%   +2.36%     
===========================================
  Files          864      205     -659     
  Lines        19529     5571   -13958     
  Branches      3893     1144    -2749     
===========================================
- Hits         14909     4385   -10524     
+ Misses        3454      863    -2591     
+ Partials      1166      323     -843
Impacted Files Coverage Δ
.../lib/task-list/components/attach-form.component.ts 35.89% <0.00%> (-15.39%) ⬇️
...ion-modules/about-application-modules.component.ts
...ntent-services/src/lib/tag/services/tag.service.ts
...orm/components/widgets/checkbox/checkbox.widget.ts
...manager/services/node-permission-dialog.service.ts
...rvices/src/lib/mock/document-library.model.mock.ts
...am/components/activities/diagram-task.component.ts
lib/core/testing/core.testing.module.ts
...s/icons/diagram-icon-box-publish-task.component.ts
...brary-name-column/library-name-column.component.ts
... and 648 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b75f7a...8bca46d. Read the comment docs.

@mauriziovitale mauriziovitale merged commit 37fef5a into develop Oct 22, 2020
@mauriziovitale mauriziovitale deleted the dev-adomi-AAE-3925 branch October 22, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauriziovitale mauriziovitale mauriziovitale approved these changes

@DenysVuika DenysVuika Awaiting requested review from DenysVuika DenysVuika is a code owner

@eromano eromano Awaiting requested review from eromano eromano is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

@sivakumar414ram sivakumar414ram Awaiting requested review from sivakumar414ram

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arditdomi @codecov-io @mauriziovitale