Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAE-3405] - Optimise attach file widget UI #6271

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Conversation

arditdomi
Copy link
Contributor

@arditdomi arditdomi commented Oct 21, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:
    Styling updates

What is the current behaviour? (You can also link to an open issue here)
https://issues.alfresco.com/jira/browse/AAE-3405

What is the new behaviour?
The attach file widget dialog size is now bigger, the search-panel UI can be expanded-collapsed and it is moved on the left
gif

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@codecov-io
Copy link

Codecov Report

Merging #6271 into develop will increase coverage by 1.95%.
The diff coverage is 70.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6271      +/-   ##
===========================================
+ Coverage    76.31%   78.27%   +1.95%     
===========================================
  Files          863      352     -511     
  Lines        19523     9632    -9891     
  Branches      3891     1950    -1941     
===========================================
- Hits         14899     7539    -7360     
+ Misses        3461     1504    -1957     
+ Partials      1163      589     -574     
Impacted Files Coverage Δ
...rm/services/content-cloud-node-selector.service.ts 33.33% <0.00%> (ø)
.../components/search-panel/search-panel.component.ts 80.00% <66.66%> (-20.00%) ⬇️
...-selector/content-node-selector-panel.component.ts 85.32% <80.00%> (-0.23%) ⬇️
...ontent-services/src/lib/mock/content-model.mock.ts 100.00% <100.00%> (ø)
...ore/notifications/services/notification.service.ts
lib/core/toolbar/toolbar-divider.component.ts
...ib/core/userinfo/components/user-info.component.ts
...nents/raphael/icons/raphael-icon-mule.component.ts
...nents/icons/diagram-icon-service-task.component.ts
lib/insights/src/test.ts
... and 509 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc81177...68bb222. Read the comment docs.

@mauriziovitale mauriziovitale merged commit 2273dd7 into develop Oct 21, 2020
@mauriziovitale mauriziovitale deleted the dev-adomi-AAE-3405 branch October 21, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants