Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADF-5170] [upload] not able to upload file/folder from external content service specfic path #6256

Merged
merged 2 commits into from
Oct 26, 2020

Conversation

dhrn
Copy link
Contributor

@dhrn dhrn commented Oct 16, 2020

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://issues.alfresco.com/jira/browse/ADF-5170

What is the new behaviour?

done

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@dhrn dhrn force-pushed the dev-dhrn-ADF-5170 branch from c11bafe to b4140fe Compare October 19, 2020 07:11
@codecov-io
Copy link

Codecov Report

Merging #6256 into develop will increase coverage by 1.84%.
The diff coverage is 55.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6256      +/-   ##
===========================================
+ Coverage    76.25%   78.09%   +1.84%     
===========================================
  Files          862      237     -625     
  Lines        19457     6577   -12880     
  Branches      3870     1281    -2589     
===========================================
- Hits         14836     5136    -9700     
+ Misses        3460     1049    -2411     
+ Partials      1161      392     -769     
Impacted Files Coverage Δ
...lib/content-widget/attach-file-widget.component.ts 69.79% <45.45%> (-1.00%) ⬇️
...ontent-widget/attach-file-widget-dialog.service.ts 63.33% <47.36%> (-28.98%) ⬇️
...tent-widget/attach-file-widget-dialog.component.ts 82.14% <90.90%> (+4.36%) ⬆️
...src/lib/document-list/data/share-data-row.model.ts 73.68% <0.00%> (-2.64%) ⬇️
...ew/directives/card-view-content-proxy.directive.ts
...ts/src/lib/diagram/components/diagram.component.ts
...k-header/components/task-header-cloud.component.ts
...sights/src/lib/diagram/models/chart/chart.model.ts
.../directives/sidenav-layout-navigation.directive.ts
lib/core/form/services/form-rendering.service.ts
... and 619 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3e8ff2...b4140fe. Read the comment docs.

@eromano eromano merged commit c6a3da2 into develop Oct 26, 2020
@eromano eromano deleted the dev-dhrn-ADF-5170 branch October 26, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants